reactiveui / website

ReactiveUI documentation and guidelines website. PR's welcome! 💖
https://www.reactiveui.net/
MIT License
35 stars 128 forks source link

Issue with docs/handbook/commands/canceling.md #90

Open SuperJMN opened 6 years ago

SuperJMN commented 6 years ago

In the last part, where does the CancellationToken come from? where is it created?

EDIT: I successfully created a Cancel command with the docs :) Sorry, I didn't see that the CancellationToken was implicit in the StartAsync call.

BTW, there's a typo: sometimes the code says "cancelable" and sometimes it is "cancellable". Please, fix it.

RLittlesII commented 6 years ago

@SuperJMN The various forms of the word cancel have bothered me for years. Technically Cancelled and Canceled are both correct. This is a divergence in the English language. Because it is a CancellationToken I tend to agree that it should be cancelled in these instances.

https://www.dictionary.com/browse/cancelable

www.dictionary.com
the definition of cancelable
Cancelable definition, to make void; revoke; annul: to cancel a reservation. See more.
ghuntley commented 6 years ago

We have a content style-guide over at https://reactiveui.net/contribute/content-style-guide/ 👍 It's based off the work that mailchimp open-sourced All content should be shaped based off the contents of the styleguide. The styleguide is the source of truth for color vs colour and how content is authored. If you think a section should be changed or burned in the style guide then send in the PR.

Content Style Guide
ReactiveUI is a composable, cross-platform model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming which is a paradigm that allows you to express the idea around a feature in one readable place, abstract mutable state away from your user interfaces and improve improve the testability of your application.