search

reactjs / core-notes

Weekly meeting notes from the React core team
900 stars 47 forks source link

Add notes for December, 8 #39

Closed gaearon closed 7 years ago

gaearon commented 7 years ago

Feel free to discuss in this PR!

aickin commented 7 years ago

As always, thanks for posting these. Two questions:

  1. I'm curious about the mentions of SSR, which make it sound like there may be some difficulties with Fiber + SSR. Can you expand on this? From the goals section, it seems that SSR will remain a supported feature in Fiber, which is great, but I would love to learn more about what the conflict is.
  2. It's really cool that Brian was able to write another renderer against Fiber's renderer API. Is this API documented in any form? I'd love to look at it and think about it if possible, though I totally understand if it isn't documented yet.
iamdustan commented 7 years ago

Re: 2. https://github.com/facebook/react/blob/master/src/renderers/shared/fiber/ReactFiberReconciler.js#L43-L71

sophiebits commented 7 years ago

  1. Currently, Fiber isn't set up to generate HTML or to revive it. There isn't any conceptual incompatibility with doing either, but it's something we need to figure out before an open source release because many people use SSR heavily. One option would be to use a separate server-side renderer like you were working on.

  2. No documentation for renderers yet but you can read through what Brian wrote here: https://github.com/reactjs/react-art/blob/c6f7a5c2972c09682911eac6752c946a60315415/src/ReactARTFiber.js#L389-L504. I can't promise that we'll find time to write docs anytime soon but I'm happy to clarify what any method does if it's confusing.

aickin commented 7 years ago

Thanks so much for the (absurdly!) quick responses and pointers to more information.

Also thanks @spicyj for the offer to clarify what the methods do! Sorry to be so nuts and bolts, but what's the best forum for that?

sophiebits commented 7 years ago

There's probably a better forum, but want to just Messenger me? https://m.me/spicyj

iamdustan commented 7 years ago

I started #react-internals on Reactiflux for this kinda purpose if either of you want to join me and a few others that hang out in there. https://discordapp.com/channels/102860784329052160/148818842779385856

Hopefully having a few additional folks may see the conversation would help to disseminate the knowledge.

gaearon commented 7 years ago

@iamdustan I’ll be there! 👍

sophiebits commented 7 years ago

If I'm being honest, I probably won't actually be responsive on Discord. I created an open Messenger room though: https://m.me/g/Abas8IcWxIvjVxHN. Hope that's not too inconvenient for interested parties.