search

reactjs / core-notes

Weekly meeting notes from the React core team
900 stars 47 forks source link

Object.assign #6

Closed evenstensberg closed 8 years ago

evenstensberg commented 8 years ago

I notice some frameworks that worked with react earlier no longer works with v15. They require the Object.assign file from the react library for their components to nest to the react Proptypes. I'm upgrading react-canvas as I saw this. This is one of many that require object.assign to nest. (See attachment) Any way to go around this?

skjermbilde 2016-04-08 kl 14 14 44

iamdustan commented 8 years ago

Update those packages to use the object-assign package?

evenstensberg commented 8 years ago

Pre v15 had the object.assign connected to internal modules. It's not that easy, I tried :smile:

gaearon commented 8 years ago

Please file an issue with those libraries. Importing anything from react/lib/ was never supported and will break. Indeed they should be using object-assign npm module.