reactjs / gu.react.dev

(Work in progress) React documentation website in Gujarati
https://gu-react-dev.vercel.app
Creative Commons Attribution 4.0 International
24 stars 8 forks source link

Translation: Editor-Setup page #6

Closed shubhamkhunt04 closed 1 year ago

shubhamkhunt04 commented 1 year ago

Translate Editor-Setup page

shubhamkhunt04 commented 1 year ago

@harshilparmar @idarshan181 @TheRakeshPurohit can anyone please review this PR?

harshilparmar commented 1 year ago

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

shubhamkhunt04 commented 1 year ago

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

@harshilparmar Yes, I have read the Gujarati Glossary table words. I would like to know, is there any mistake in the current PR?

harshilparmar commented 1 year ago

@shubhamkhunt04 Have you reviewed Glossary section? If not can you please check once?

@harshilparmar Yes, I have read the Gujarati Glossary table words. I would like to know, is there any mistake in the current PR?

I have found few changes where exact translation is not conveying the meaning in Gujarati. I will mention it here.

Note: Its good to use translation service as assistant but it should be align with Gujarati grammar and context.

shubhamkhunt04 commented 1 year ago

@harshilparmar could you please let me know what changes are needed so I can fix it?

idarshan181 commented 1 year ago

@harshilparmar could you please let me know what changes are needed so I can fix it?

@shubhamkhunt04 I have suggested some changes to specific lines. Please review them and make the necessary revisions.

shubhamkhunt04 commented 1 year ago

@idarshan181 My system is not showing the changes you suggested. Have you submitted them?

Screenshot 2023-06-15 at 5 01 28 AM
shubhamkhunt04 commented 1 year ago

@idarshan181 @harshilparmar Thank you for your feedback. I made the changes. Please re-review.

shubhamkhunt04 commented 1 year ago

@harshilparmar changes done, Please re-review

harshilparmar commented 1 year ago

@shubhamkhunt04 Ok thanks, I don't think there is anything left but I will review it over the weekend and give my last suggestion if any.

shubhamkhunt04 commented 1 year ago

@shubhamkhunt04 Ok thanks, I don't think there is anything left but I will review it over the weekend and give my last suggestion if any.

Sure!

shubhamkhunt04 commented 1 year ago

@harshilparmar @idarshan181 @TheRakeshPurohit Could you please let me know if there have been any updates on this pull request (PR)? I appreciate your time and attention on this PR. Let me know if anything needs to be changed. Thanks again!

shubhamkhunt04 commented 1 year ago

@harshilparmar changes are done!

github-actions[bot] commented 1 year ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 This PR introduced no changes to the JavaScript bundle! 🙌
harshilparmar commented 1 year ago

Thanks @shubhamkhunt04 🥳 Congratulation for contributing to first translation page of react gujarati.

shubhamkhunt04 commented 1 year ago

Thanks @shubhamkhunt04 🥳 Congratulation for contributing to first translation page of react gujarati.

@harshilparmar Thank you so much :D