search

reactjs / react-autocomplete

WAI-ARIA compliant React autocomplete (combobox) component
MIT License
2.17k stars 532 forks source link

Deprecate string ref #196

Closed teameh closed 7 years ago

teameh commented 7 years ago

Rebased and cleaned up version of https://github.com/reactjs/react-autocomplete/pull/173

LGTM!

@alvinsj I hope you're alright with me cleaning up your commit.

CMTegner commented 7 years ago

Contradictory to what I wrote in #173, I don't think we can actually land this in 1.0. I know of several production apps that would break if we rename the (undocumented) refs. Currently refs are the only way of accessing the imperative API of the inner <input>.

I have some ideas on how to solve this for 2.0.

teameh commented 7 years ago

I don't think we can actually land this in 1.0. I know of several production apps that would break if we rename the (undocumented) refs.

Haha okay.. But then you can't make any breaking changes in 1.0?

Currently refs are the only way of accessing the imperative API of the inner .

Shouldn't that be included in v1.0 as well then?

teameh commented 7 years ago

I have some ideas on how to solve this for 2.0.

Ah I've your comment read too fast, okay, yeah that might make sense, you could also skip v1.0 altogether.

CMTegner commented 7 years ago

Fixed in f915315bfd89b6ab77b2125192b621cde609d1dc. We're still using the this.refs namespace for backwards compatibility.