reactjs / react-autocomplete

WAI-ARIA compliant React autocomplete (combobox) component
MIT License
2.17k stars 532 forks source link

[fixed] maybeScrollItemIntoView exception when itemNode is not found #281

Closed faviktor92 closed 6 years ago

CMTegner commented 6 years ago

It's difficult to know why you want to perform this change, since you've provided no context, but I'm assuming it's because you've implemented a renderMenu function which doesn't always return every item to be rendered. This edge case is already documented:

Ensure the returned tree includes every entry in items or else the highlight order and keyboard navigation logic will break.