search

reactjs / react-autocomplete

WAI-ARIA compliant React autocomplete (combobox) component
MIT License
2.17k stars 532 forks source link

Unlocked dependencies and possibly issue with custom-menu example #321

Open flash1293 opened 6 years ago

flash1293 commented 6 years ago

It makes sense to lock down the depenencies by checking in the package-lock.json and maybe even yarn.lock files.

This could prevent non-repeatable builds further down the line. I suspect there is already an issue with this - a fresh checkout with npm install && npm start gives me the attached behavior in the custom-menu example. The same example on https://reactcommunity.org/react-autocomplete/custom-menu/ looks fine. (macOS 10.13.3, Chrome 66.0.3354.0)

http://localhost:8080/custom-menu/:

screen shot 2018-02-25 at 10 56 26 am

https://reactcommunity.org/react-autocomplete/custom-menu/

screen shot 2018-02-25 at 11 00 53 am
flash1293 commented 6 years ago

It works fine for me locally with version 1.7.3, maybe https://reactcommunity.org/react-autocomplete/custom-menu/ isn't updated yet.