enable line chart to change it colors dynamically

reactjs / react-chartjs

common react charting components using chart.js

MIT License

2.93k stars 301 forks source link

enable line chart to change it colors dynamically #101

Open 5c077yP opened 8 years ago

5c077yP commented 8 years ago

Hey,

we recently introduced this lib into our own app and i noticed that one cannot change the line chart color dynamically. Looking at the code shows that only datapoints are updated, but updating other properties from the dataset can also be updated (i tested that locally).

So here the PR, this enables the Line Chart to update it's colors dynamically without setting the redraw attribute.

5c077yP commented 8 years ago

Hey any plans on looking at this ?

austinpray commented 8 years ago

April 11, yikes!

I just tested this and it works. However, I would much prefer a whitelist of things that are known to not cause trouble rather than blacklisting "data".

benmccann commented 6 years ago

@5c077yP this PR needs to be rebased