search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

direct assignment to this.state? #121

Open yocontra opened 8 years ago

yocontra commented 8 years ago

https://github.com/jhudson8/react-chartjs/blob/master/lib/core.js#L64

I'm having some issues where this.state.chart doesn't exist and is causing errors to be spewed all over, noticed this while checking things out. I don't think direct assignment of this.state is supported and might be why the issue is happening.

austinpray commented 8 years ago

That should def be a setState, I don't see why it would be anything else

ledsun commented 8 years ago

I think this is no problem, because the react-chartjs has no child components.