search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

v2 release/roadmap? #154

Open crobinson42 opened 7 years ago

Jareechang commented 7 years ago

Hey, I don't have a release or roadmap but I am planning to do some work on the library.

It'll be on the branch chartjs-v2. Is there anything in particular you guys think would be nice or are missing from that current branch ? I know someone has already added support for the new Chart.js version 2.0 + chart types

philipwalton commented 7 years ago

For my use cases the 2.0 version of ChartJS works with this library, but I'm still getting an npm warning when installing.

Unless there's a known conflict with 2.0 (that I'm just not experiencing), I'd at least like to see the peerDependency less restrictive.

Jareechang commented 7 years ago

@philipwalton, you are right, for some core features it should be no problem.

However, I've noticed some features in this version start to break for Chart.js V2. This library has bound onto some methods only specific to V1 when initializing some of the charts.

One example is the getPointsAtEvent(e) method in Chart.js V1 which is deprecated and changed to getElementsAtEvent(e) in Chart.js V2 :(

merlinstardust commented 7 years ago

@Jareechang @austinpray when is it planned for v2 to fully replace v1 and get published to npm?

crobinson42 commented 7 years ago

A @next release tag in npm would be nice.

On May 14, 2017 8:44 AM, "Merlin Patterson" notifications@github.com wrote:

@Jareechang https://github.com/jareechang @austinpray https://github.com/austinpray when is it planned for v2 to fully replace v1 and get published to npm?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/reactjs/react-chartjs/issues/154#issuecomment-301321113, or mute the thread https://github.com/notifications/unsubscribe-auth/AFsmS3SfN_cqu2zFckcd9Go5Fg257rRYks5r5yFMgaJpZM4KYFW- .

austinpray commented 6 years ago

If someone wants to spearhead this I can def give them contribution and npm access.

benmccann commented 6 years ago

@gor181 would you like access to merge your fixes into this repo and release a new version per @austinpray's last comment?

gor181 commented 6 years ago

@benmccann I have handed the repo to @jerairrest due to lack of time. So leaving up to him to decide. Thanks for mentioning 👍

jerairrest commented 6 years ago

@benmccann I would be all for combining the repos together instead of having them fragmented for each major version of chart-js!

austinpray commented 6 years ago

@jerairrest I sent you contributor access. Let me know if you need anything else!

jerairrest commented 6 years ago

Are we wanting just the index.js to be merged in? Or everything including the Typescript definitions, old tests as well as the storybook?

benmccann commented 6 years ago

@jerairrest I would leave it to your discretion to merge anything you think is of value. I know @ianks was wanting Typescript definitions in https://github.com/reactjs/react-chartjs/issues/84#issuecomment-232771416

benmccann commented 6 years ago

@jerairrest I think the main thing to think through is that lib/core.js in this repo is a bit different from jerairrest/react-chartjs-2/src/index.js. We should try to make sure we're taking the best ideas from both and combining them when we merge. Perhaps you'd be able to summarize the main differences between the approaches?

austinpray commented 6 years ago

@jerairrest @benmccann btw both of you guys have npm access now.

Recommend releasing the current master as 1.0.0 and then whatever breaking changes ya'll do in the merge release a 2.0.0

nanomosfet commented 6 years ago

Need any help with this? Not having up to date chart js is annoying for me because chart.js only has this github source for the source so i'm willing to put in some work to get it done.