search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 300 forks source link

Some es6 conversions, removed deprecated methods and added support for horizontal bar #157

Closed Jareechang closed 6 years ago

Jareechang commented 7 years ago

as stated in the title, plenty of changes.

Main Changes:

  1. Some ES6 conversion
  2. Removed Deprecated Methods
    • PointsAtEvent(e), AddData and removeData
  3. Add support for new Methods
    • render,getElementAtEvent, getElementsAtEvent, getDatasetAtEvent, getDatasetMeta
  4. Added support for horizontal bars
    • moved ternary expression into a dictionary method — convertToValidChartType
Jareechang commented 7 years ago

hey @austinpray, can you have a look at this PR when you get chance please 😄, thank you!

austinpray commented 7 years ago

Yes I'll take a look!

chaliy commented 7 years ago

Any chance?

benmccann commented 6 years ago

@Jareechang this PR needs to be rebased

Jareechang commented 6 years ago

@benmccann, ok. I will have a look later this week.

Jareechang commented 6 years ago

hey @benmccann, I may have to nuke these changes and PR on top of the latest code base.

There are just too many merge conflicts for me to properly track what is happening. Please close this PR. Thanks.

benmccann commented 6 years ago

Ok. Thanks for that. And sorry for the delay in getting your PR reviewed

Btw, you had 4 changes listed in the description. If you're able to open new PRs for these, can you do them as separate PRs?

Thanks again