search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

Upgraded to support chart.js v2.5.0 #174

Closed suraj closed 7 years ago

suraj commented 7 years ago

Primarily, the way Chart object is created( in core.js) has changed. Added few new methods introduced in V2.

psykhi commented 7 years ago

@suraj I think you forgot some changes in core.js. I am not using chart.scale and get exceptions when going though the line while (chart.scale.xLabels.length > nextProps.data.labels.length) {

    at updatePoints (core.js:132)
    at Object.classData.componentWillReceiveProps (core.js:48)

I am trying to update a bar chart with new data in that case.

austinpray commented 7 years ago

this should be PRed against the chartjs-v2 branch. Sorry for the confusion. I can add a note to the README.