reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

Does this work with Browserify? #3

Closed sylg closed 9 years ago

sylg commented 9 years ago

I'm getting this error in the browser:

Uncaught Error: The charts were not initialized with the React instance

with this sample test:

// main.js
var React = require('react');
var LineChart = require("react-chartjs/line");

var newData = {
    labels: ["January", "February", "March", "April", "May", "June", "July"],
    datasets: [
        {
            label: "My First dataset",
            fillColor: "rgba(220,220,220,0.2)",
            strokeColor: "rgba(220,220,220,1)",
            pointColor: "rgba(220,220,220,1)",
            pointStrokeColor: "#fff",
            pointHighlightFill: "#fff",
            pointHighlightStroke: "rgba(220,220,220,1)",
            data: [65, 59, 80, 81, 56, 55, 40]
        },
        {
            label: "My Second dataset",
            fillColor: "rgba(151,187,205,0.2)",
            strokeColor: "rgba(151,187,205,1)",
            pointColor: "rgba(151,187,205,1)",
            pointStrokeColor: "#fff",
            pointHighlightFill: "#fff",
            pointHighlightStroke: "rgba(151,187,205,1)",
            data: [28, 48, 40, 19, 86, 27, 90]
        }
    ]
};

var Test = React.createClass({
  render: function() {
    return (
        <LineChart data={newData} options={{scaleShowGridLines : true}} width="600" height="250" />
    );
  }

});

React.render(<Test />, document.body);

React (via Browserify) work fine alone if remove everything related to react-chartjs...

If I fall back to just using script tags to load chart.js and react-chartjs, everything works fine.

jhudson8 commented 9 years ago

Looks like you didn't follow the install instructions (see README.md). You must do this once before you use the charts.

// initialize ReactChartjs
require('react-chartjs/vars').React = React;
jhudson8 commented 9 years ago

FYI, the next release won't require this

jhudson8 commented 9 years ago

this change has been made in v0.2.0

sylg commented 9 years ago

Thanks for the quick reply. Awesome :+1: