search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

Make react-charts compatible with react@0.14.0-rc1 #48

Closed dmr closed 8 years ago

dmr commented 8 years ago

But react 0.14 isn't released yet and it might break compatibility so I'm not sure if this should be merged yet

dmr commented 8 years ago

package.json refers a "test" command but I don't see any tests

gustavoguichard commented 8 years ago

I think this should be merged now because react 0.14 was released already. And also, getDOMNode() was already deprecated in react 0.13.

Anahkiasen commented 8 years ago

:+1:

santiagoaguiar commented 8 years ago

+1 needing this one to move forward to 0.14.

tomfairbs commented 8 years ago

Yep, +1 from me as well. Would also be a good idea to update the compiled versions in /dist.

sspross commented 8 years ago

+1

siemya commented 8 years ago

+1

dmr commented 8 years ago

Do I read correctly that this pull request is outdated and peerDependencies are the way to got and #54 already added all the things that I didn't?

eanplatter commented 8 years ago

@dmr yeah, it looks like #54 covers it all.

dmr commented 8 years ago

Well, then we can just close this :)