search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

Update Chartjs to Chart #49

Closed gustavoschmidt closed 8 years ago

gustavoschmidt commented 8 years ago

The actual module exported from Chart.js is 'Chart' and not 'Chartjs'.

joshhornby commented 8 years ago

I am correct in saying this is a breaking change and not sure what benefit there is to merging.

gustavoschmidt commented 8 years ago

Thanks for your reply @joshhornby. I'm using react-chartjs as global variable in my application, and the exported variable from Chart.js is Chart and not Chartjs (https://github.com/nnnick/Chart.js/blob/master/Chart.js#L2014). So to make they work together I needed to create another global variable name Chartjs. But I shouldn't have changed all the references to Chartjs, only the root. I'm gonna update this PR soon.

austinpray commented 8 years ago

This PR is before my time. Do apologize for having it languish this long.