search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 299 forks source link

React and Chart.js are not peerDependencies #51

Closed apaleslimghost closed 8 years ago

apaleslimghost commented 9 years ago

peerDependencies aren't things you require, they're things that your module works alongside of (e.g. Grunt plugins have Grunt as a peerDependency). Moreover, since npm 3.0, they're not installed automatically when you install a module.

Since you require React and Chart.js, they're regular dependencies. You should move them to dependencies in package.json and give them version constraints (e.g. this library doesn't yet work with React 0.14, so in the dependencies hash it should have "react": "<=0.13").

raylenmargono commented 9 years ago

hello is this a response to my issue?

apaleslimghost commented 9 years ago

No?

joshhornby commented 8 years ago

Feel free to submit a PR for this.

jxm262 commented 8 years ago

@joshhornby I have a bit of free time today. Will try to submit a PR soon

austinpray commented 8 years ago

this is fixed

apaleslimghost commented 8 years ago

Unless I'm missing something, no, it's not.