search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

Fix to work with HTTPS #60

Closed mivade closed 8 years ago

mivade commented 8 years ago

Explicitly specifying http to load libs from the CDN causes failures on modern browsers if the HTML page was loaded via https (e.g., this can happen if using the HTTPS Everywhere extension).

This also switches out the CDNs for zepto and underscore primarily because it doesn't seem like zepto uses HTTPS.

austinpray commented 8 years ago

Thank you for this!

Do you mind just changing // to https://? I don't want to load http:// under any circumstances so protocol relative is not appropriate. After you do this can you then rebase into 1 commit?

mivade commented 8 years ago

I agree that always using https is the better behavior. I have made that change and rebased.

austinpray commented 8 years ago

Thank you!