search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 299 forks source link

PieChart.getDOMNode(...) is deprecated. Please use ReactDOM.findDOMNode(instance) instead. #64

Closed i-kitaev closed 8 years ago

joshhornby commented 8 years ago

Please submit a PR and I will merge.

kasperfilstrup commented 8 years ago

Hi @joshhornby . I saw you accepted the pull request with the fix for this, but it isn't present when npm install react-chartjs. Any idea when this will get pushed to npm? (or any tips to how I can get it with npm until it is "published"?) :-)

slavovojacek commented 8 years ago

@kasperwf :+1:

joshhornby commented 8 years ago

@kasperwf https://docs.npmjs.com/files/package.json#repository Should do the trick.

@jhudson8 Can you update the npm version please?

kasperfilstrup commented 8 years ago

Great @joshhornby - thanks a lot! :-D

It turns out it's as simple as changing "react-chartjs": "^0.6.0" to "react-chartjs": "jhudson8/react-chartjs", in package.json

GitHub urls

pkibbey commented 8 years ago

It looks like the PR was merged, but the files in dist were not rebuilt, so I'm still getting the same getDOMNode error.

underwater commented 8 years ago

It appears that the dist folder is 9 months old still, is it possible to do that so as to get rid of the various errors I am getting on my dashboard source

pkibbey commented 8 years ago

I'll run the build and dist commands (npm run build, npm run dist) then submit a new pull request... give me a few minutes...

pkibbey commented 8 years ago

I'm having network issues, so I can't install the required packages...

Try this

  1. clone repo
  2. run "npm install" in the directory
  3. run "npm run dist"
  4. Submit pull request.

that 'should' work.... hopefully.

underwater commented 8 years ago

Hi there, thanks for your quick response, Tried that my side, and getting this 8 info react-chartjs@0.7.3 Failed to exec dist script 9 error react-chartjs@0.7.3 dist: COMPRESS=1 webpack index.js dist/react-chartjs.min.js 9 error Exit status 1 10 error Failed at the react-chartjs@0.7.3 dist script.

pkibbey commented 8 years ago

I finally managed to get this running locally, and have submitted a pull request ^^

teone commented 8 years ago

Looks like it is not available yet on NPM, but works if I set "react-chartjs": "jhudson8/react-chartjs" in package.json

I just don't feel safe not locking the version.

lchngr commented 8 years ago

Can you please push the new version to the npm repo. Thx

patrickkempff commented 8 years ago

It looks like the current version (0.7.3) is not yet published on npm. @jhudson8 It is possible to push it? thanks.

austinpray commented 8 years ago

@patrickkempff I just published the latest version, lemme know if this fixes it

suancarloj commented 8 years ago

@austinpray 0.7.3 works for me :) thx