search

reactjs / react-chartjs

common react charting components using chart.js
MIT License
2.93k stars 301 forks source link

(feat) Chart.js 2.0-dev compatibility #87

Closed danmolitor closed 8 years ago

danmolitor commented 8 years ago

After reading about Chart.js 2.0's performance upgrades, I've updated react-chartjs to be compatible with the Chart.js most up to date 2.0-dev branch, including the new bubble and scatter charts. By moving from 1.0.2 to 2.0, the time it takes a simple line-chart to render has dropped significantly.

Since people may still want to use Chart.js v1.0.2., if you don't want to merge yet people can still use this version by updating their dependencies in their project's package.json to:

"chart.js": "git://github.com/danmolitor/Chart.js.git#v2.0-dev", "react-chartjs": "git+https://github.com/danmolitor/react-chartjs.git"

I've attached a image showing the original charts using Chart.js v2.0-dev.

react-chartjs2

RamonBeast commented 8 years ago

+1

austinpray commented 8 years ago

Thank you for the PR!

I made a branch here: https://github.com/jhudson8/react-chartjs/tree/chartjs-v2

Can you resubmit this PR against this branch so we can consolidate effort towards v2?

danmolitor commented 8 years ago

Definitely! I'll do that now.

danmolitor commented 8 years ago

Hey Austin!

Just making sure I do this correctly, is the best way to do this by closing this PR, and reopening a new one to the new branch?

austinpray commented 8 years ago

Yep, close and recreate the PR.

related: https://github.com/isaacs/github/issues/18