search

reactjs / react-codemod

React codemod scripts
MIT License
4.21k stars 290 forks source link

update-react-imports changes line endings (LF -> CRLF) #281

Open tpettrov opened 4 years ago

tpettrov commented 4 years ago

I recently started update-react-imports and it works as expected but re-wrote the line endings from LF to CRLF, probably because I'm on Windows but would expect that it doesn't change them if possible.

threepointone commented 4 years ago

This is functionality from jscodeshift, so the issue should probably be filed there. However, one of the assumptions we have about people running codemods, is that they also run something like prettier (or whatever your code formatter is) manually after running the codemod. Does that advice seem reasonable in this case?

tpettrov commented 4 years ago

Advice is reasonable due to the fact that the issue should probably be filled to jscodeshift :) Thank you.