search

reactjs / react-modal

Accessible modal dialog component for React
http://reactcommunity.org/react-modal
MIT License
7.37k stars 808 forks source link

Peer dependencies not working with react 18+ #1005

Closed raphaelguimaraeszup closed 1 year ago

raphaelguimaraeszup commented 1 year ago

Summary:

I upgraded my react & react dom dependencies to 18.2.0 and when I try to run npm i my build process is breaking.

Steps to reproduce:

  1. Update React & React to v18+
  2. Try run npm i

Expected behavior:

Install and build the project.

Link to example of issue:

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0 || ^16 || ^17" from react-modal@3.14.4

Additional notes:

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0 || ^16 || ^17" from react-modal@3.14.4
diasbruno commented 1 year ago

@raphaelguimaraeszup Essa versao do react-modal eh antiga. Atualize.

diasbruno commented 1 year ago

Prefira v3.16+.

diasbruno commented 1 year ago

A @ZupIT em peso nos like... :joy:

diasbruno commented 1 year ago

@raphaelguimaraeszup deu bom?

raphaelguimaraeszup commented 1 year ago

@diasbruno minha versão já está na indicada "react-modal": "^3.16.1",

raphaelguimaraeszup commented 1 year ago

@diasbruno refiz o teste aqui, excluindo a node modules e só rodando npm i aparentemente resolveu para essa dependência sim, agora estou com problema em outra. Devo ter feito o último teste antes de ter atualizado para essa versão 3.16.x, obrigado.