[fixed] strict matching for tabbable nodes

reactjs / react-modal

Accessible modal dialog component for React

http://reactcommunity.org/react-modal

MIT License

7.37k stars 808 forks source link

Closed bouncehead13 closed 9 months ago

bouncehead13 commented 1 year ago

Fixes #1014.

Changes proposed:

Acceptance Checklist:

[X] The commit message follows the guidelines in CONTRIBUTING.md.
[X] Documentation (README.md) and examples have been updated as needed.
[X] If this is a code change, a spec testing the functionality has been added.
[ ] If the commit message has [changed] or [removed], there is an upgrade path above.

diasbruno commented 1 year ago

LEGIT. I'll have a better look later. Bom trabalho!

bouncehead13 commented 1 year ago

@diasbruno Following up to see if we could move this forward and start gathering feedback.

diasbruno commented 1 year ago

Thanks for "ping". I'll review it later.

diasbruno commented 1 year ago

@bouncehead13 Can you rebase your PR please? I've fixed the action issue.

bouncehead13 commented 1 year ago

@diasbruno all set. Updated to the latest with GH Action changes.

bouncehead13 commented 1 year ago

@diasbruno Is there anything remaining I can help with to move this forward?

bouncehead13 commented 1 year ago

@diasbruno More of my teams are facing this problem breaking accessibility. It would be great to have this merged in with a new release. Thanks!

doeg commented 9 months ago

Hey @diasbruno! :) I wanted to see if there's anything I can do to be helpful to get this one merged. 🙇

diasbruno commented 9 months ago

Thanks, @doeg. I'll make a release later.

diasbruno commented 9 months ago

Also, thanks @bouncehead13. For taking the time to work on this, and, I'm sorry it took so long to merge.