Fixed/988 - Make setAppElement or appElement required - Githubissues

reactjs / react-modal

Accessible modal dialog component for React

http://reactcommunity.org/react-modal

MIT License

7.34k stars 807 forks source link

Fixed/988 - Make setAppElement or appElement required #998

Closed diasbruno closed 1 year ago

diasbruno commented 1 year ago

Fixes #988.

Changes proposed:

One of the options to set the app element are going to be required because we can't use document.body as default (hides all elements on the page).

Upgrade Path (for changed or removed APIs):

Must use one of the options.

Acceptance Checklist:

[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.