search

reactjs / react-php-v8js

PHP library that renders React components on the server
Other
1.33k stars 127 forks source link

Prevent code execution in constructor #14

Open jibriss opened 9 years ago

jibriss commented 9 years ago

Hello,

Here is a little refactoring to prevent code execution in constructor.

This will execute the javascript library only when needed. This will also allow people to register their errorHandler before these library are executed.

facebook-github-bot commented 9 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 9 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!