Issue new release - Githubissues

reactjs / react-php-v8js

PHP library that renders React components on the server

Other

1.33k stars 127 forks source link

Issue new release #21

Closed sisve closed 8 years ago

sisve commented 8 years ago

The current stable (1.0.0) is behind the master branch with some important commits that fixes deprecation warnings like "Warning: React.renderToString is deprecated. Please use ReactDOMServer.renderToString from require('react-dom/server') instead.". A workaround is using dev-master and minimum-stability:dev which makes my skin itch...

The relevant commit: https://github.com/reactjs/react-php-v8js/commit/05637dbb62fa139b7edacfaf782341d9c9e8c34f

zpao commented 8 years ago

What's the typical way people declare their composer dependencies? If I tag master as 1.1.0, is that likely to break a bunch of people? Should I just call it 2.0.0 to be safe?

sisve commented 8 years ago

I don't think that you need to consider how people have referenced your library, if they wanted an explicit version they would have explicitly referred to that. Just make sure you're consistent in your versioning and following the semver rules.

Are all changes internal backward compatible bug-fixes? Then it's a 1.0.1.
Is there new functionality but the public api is backward compatible? Then it's a 1.1.0.
Are there backwards incompatible changes in the public api? Then it should be 2.0.0.

zpao commented 8 years ago

tagged master as 2.0.0