search

reactjs / react-php-v8js

PHP library that renders React components on the server
Other
1.33k stars 127 forks source link

Fix to ensure that global, self, and window are all pre-defined #6

Closed jbroadice closed 9 years ago

jbroadice commented 9 years ago

See similar: https://github.com/reactjs/react-rails/pull/84

facebook-github-bot commented 9 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot commented 9 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

zpao commented 9 years ago

lgtm, thanks!

jbroadice commented 9 years ago

Thank you! :+1: