search

reactjs / react-tutorial

Code from the React tutorial.
http://facebook.github.io/react/docs/tutorial.html
Other
3.29k stars 2.13k forks source link

set encoding `utf-8` for the reader and the writer of the file `comments.json` #136

Closed yepzy closed 1 year ago

yepzy commented 8 years ago

The web page will had some problem of encoding of the ', with the server in python so, I have corrected it, by adding encoding="utf-8"when the files comments.json is opened

InceptionCode commented 8 years ago

I think you have to give me access in order to merge the request.

zpao commented 8 years ago

@InceptionCode I believe you may be commenting on the wrong repo.

InceptionCode commented 8 years ago

@zpao Your right I apologize my repo has the same name.

zpao commented 8 years ago

No worries :)

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.