Tutorial page "Lifting State Up" demo can give incorrect boiling verdict

[PeterVermont]

Because the Boiling verdict uses the temperature in celsius , if the user puts in fahrenheit 211.9999 this will incorrectly report that it will boil. This is because the conversion to celsius is limited to 3 digits and gets rounded up to 100.

A fix for this is to change BoilingVerdict to accept scale and temperature and the code to do a slightly different check for each:

function BoilingVerdict(props) {
  if (props.scale === 'c' ? props.temperature >= 100 : props.temperature >= 212) {
    return <p>The water would boil.</p>;
  }
  return <p>The water would not boil.</p>;
}

        <BoilingVerdict
          scale={this.state.scale}
          temperature={this.state.temperature} 
          />

I know that I could do a fork and pull request but this is about as far as my interest in this subject goes so anyone else is free to fix this admittedly tiny issue.

[kambleaa007]

I observed that, Now even temp in Celsius is 100, still its showing not boil, its wrong,

its wrong,

its right,

any quick fix in code.

[kambleaa007]

created PR https://github.com/reactjs/reactjs.org/pull/1989 Have a look, Suggest any changes if needed

[dptole]

That is not the only problem with that page

In Elm

https://ellie-app.com/85gDTH7H5zBa1