search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
11.06k stars 7.56k forks source link

Invalid Hook Call Warning: Rules of hooks broken when multiples React instances rendered #3630

Open bologer opened 3 years ago

bologer commented 3 years ago

At the very bottom of "Invalid Hook Call Warning" page (https://reactjs.org/warnings/invalid-hook-call-warning.html) it says the following:

Note In general, React supports using multiple independent copies on one page (for example, if an app and a third-party widget both use it). It only breaks if require('react') resolves differently between the component and the react-dom copy it was rendered with.

However it has no explanation on how to ensure there is no collision between multiple React instances.

I am building an embeddable React widgets and very recently I matched the following error: 

Error: Minified React error #321; visit https://reactjs.org/docs/error-decoder.html?invariant=321 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at Object.xo (embed.js:formatted:4213)
    at exports.useMemo (embed.js:formatted:487)
    at StarRating (ComponentName.88cd42c6.js:8)
    at _o (embed.js:12)
    at hi (embed.js:12)
    at Gi (embed.js:12)
    at Yi (embed.js:12)
    at Ki (embed.js:12)
    at Vi (embed.js:12)
    at embed.js:12

Which decodes to the following error message:

Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons: 1. You might have mismatching versions of React and the renderer (such as React DOM) 2. You might be breaking the Rules of Hooks 3. You might have more than one copy of React in the same app See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

After some analysis, 1) is not true, both react and react-dom are matching, 2) rules of hooks are not broken (useMemo() at the very top of functional component), 3) most likely related to it.

The third point I can't control, because website can have various React widgets on the same page which developed by other companies.

I check the following thread but it didn't help me. And it seems to be an issue for some users as well.

What to do in this case?

MatanBobi commented 3 years ago

This seems like more of a question for stackoverflow rather than here but I'll share my opinion. If you're embedding your code not through an iframe and your code may run on sites already using react , you'll probably need to state react and react-dom as peerDependencies and not as dependencies. For sites which don't include react already, you'll have them as a dependency.