search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
10.86k stars 7.45k forks source link

"Rules of React" docs would cause TypeError #6903

Open reko-aviary opened 1 month ago

reko-aviary commented 1 month ago

The example here would cause a TypeError: Assignment to constant variable.

https://github.com/reactjs/react.dev/blob/f055f8f3c2c9a8e5dbfe3a57e5a63b7769075abc/src/content/reference/rules/components-and-hooks-must-be-pure.md?plain=1#L236-L241

ijayhub commented 1 month ago

is it still valid... can i work on this?

reko-aviary commented 1 month ago

is it still valid... can i work on this?

There's already a PR for this https://github.com/reactjs/react.dev/pull/6905

ijayhub commented 1 month ago

Okay... Thanks for letting me know

On Mon, 27 May 2024, 12:38 pm Reko Jokelainen, @.***> wrote:

is it still valid... can i work on this?

There's already a PR for this #6905 https://github.com/reactjs/react.dev/pull/6905

— Reply to this email directly, view it on GitHub https://github.com/reactjs/react.dev/issues/6903#issuecomment-2133293358, or unsubscribe https://github.com/notifications/unsubscribe-auth/APYOQHKRBI6GNKSCQ7ZHI2DZEMLNFAVCNFSM6AAAAABIE5LWFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGI4TGMZVHA . You are receiving this because you commented.Message ID: <reactjs/react. @.***>