reactjs / react.dev

The React documentation website

https://react.dev/

Creative Commons Attribution 4.0 International

11.07k stars 7.55k forks source link

Fix: replace broken Placekitten placeholder images with Loremflickr #6927

Closed aaron-mota closed 1 month ago

aaron-mota commented 5 months ago

Description

Placekitten (cat placeholder images) seems to be down.

Changes Made

I've replaced the placekitten urls with loremflickr urls, another free placeholder image service that can supply cat images. It's already being used elsewhere within the codebase for cat images, and allows width and height parameters to be passed (so that the image dimensions of the original placeholders could be matched). This change could be used just temporarily if placekitten being down is also temporary.

Code of Conduct

This pull request adheres to the project's Code of Conduct.

Screenshots

(React docs) Example: Scrolling to an element

Before change (placekitten):
After change (loremflickr):

(React docs) Challenge: Scrolling an image carousel

Before change (placekitten):
After change (loremflickr):

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
19-react-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 2, 2024 1:59am
react-dev	✅ Ready (Inspect)	Visit Preview		Jun 2, 2024 1:59am

facebook-github-bot commented 5 months ago

Hi @aaron-mota!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

github-actions[bot] commented 5 months ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 This PR introduced no changes to the JavaScript bundle! 🙌

aaron-mota commented 5 months ago

Signed the CLA. Waiting for that to take effect and will rerun the GAs

UPDATE: not sure when it's going to take effect... ("up to 1 hour" was 24 hours ago)

rickhanlonii commented 1 month ago

Fixed by https://github.com/reactjs/react.dev/pull/7189