search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
11k stars 7.51k forks source link

code improvement #6929

Closed JohnKimaiyo closed 3 months ago

JohnKimaiyo commented 3 months ago
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ❌ Failed (Inspect) Jun 2, 2024 0:53am
react-dev ❌ Failed (Inspect) 💬 Add feedback Jun 2, 2024 0:53am
facebook-github-bot commented 3 months ago

Hi @JohnKimaiyo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

rickhanlonii commented 3 months ago

As you can see by the failed tests, this breaks our formatting rules. We don't generally accept PRs that only change formatting.