reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
11.07k stars 7.55k forks source link

[Typo]: createPortal documentation is pointing to an old page of W3C dialog modal docs. #6951

Open PedroBarbosaSw opened 5 months ago

PedroBarbosaSw commented 5 months ago

Summary

createPortal documentation redirect us to the wrong W3C guideline page (old page).

Page

https://react.dev/reference/react-dom/createPortal#usage

Details

The createPortal documentation (Pitfall section) has a link that points to the W3C guidelines page on how to make modals accessible. Although, this link is an old one so this is not currently redirecting to the expected one. The new link is https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/.

Rekl0w commented 5 months ago

You looks like made the changes first, go ahead.

baskargopinath commented 5 months ago

thanks @Rekl0w