search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
10.86k stars 7.45k forks source link

Fix Page Scrolling Behavior After Closing Algolia Search Bar #6957

Open sreenath-here opened 1 week ago

sreenath-here commented 1 week ago

Description:

This pull request addresses an issue where the website would scroll back to the top of the page after closing the Algolia search bar, regardless of the user's initial position on the page.

Issue:

Whenever the Algolia search bar is activated or clicked, and then subsequently closed, the page scrolls back to the top. This disrupts the user's experience, especially if they were in the middle of reading content further down the page.

Solution:

The following changes were made to resolve this issue:

  1. Implemented state management to store the user's scroll position before the search bar is activated.
  2. Ensured that the scroll position is restored when the search bar is closed.
  3. Added event listeners to manage scroll behavior effectively.

Changes:

  1. Added a state variable to store the scroll position.
  2. Modified the search bar activation and deactivation logic to handle scroll position.
  3. Updated relevant components to ensure seamless user experience.

Testing:

Tested on multiple pages to ensure the scroll position is correctly maintained after closing the search bar. Verified that the fix does not introduce any new issues or regressions.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 3:49pm
react-dev ✅ Ready (Inspect) Visit Preview Jun 16, 2024 3:49pm
github-actions[bot] commented 1 week ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 ### Five Pages Changed Size The following pages changed size from the code in this PR compared to its base branch: Page | Size (compressed) | First Load | |---|---|---| | `/404` | `80.83 KB` _(🟡 +44 B)_ | 184.98 KB | | `/500` | `80.83 KB` _(🟡 +44 B)_ | 184.97 KB | | `/[[...markdownPath]]` | `82.68 KB` _(🟡 +44 B)_ | 186.82 KB | | `/errors` | `81.04 KB` _(🟡 +44 B)_ | 185.19 KB | | `/errors/[errorCode]` | `81.02 KB` _(🟡 +44 B)_ | 185.16 KB |
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

sreenath-here commented 1 week ago

Screenshots:

Before:

https://github.com/reactjs/react.dev/assets/122635878/3286ae06-d972-41ce-9dc5-af0d8b2eba1d

After:

https://github.com/reactjs/react.dev/assets/122635878/1dc77edf-9201-4a3e-9518-6af95b044800