reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
11k stars 7.51k forks source link

Add branding context menu #6986

Closed rickhanlonii closed 3 months ago

rickhanlonii commented 3 months ago

Overview

Adds a menu when you right click the top nav logo to copy the logos and colors.

Screens

Dark mode

Screenshot 2024-06-20 at 10 48 46 AM

Light mode

Screenshot 2024-06-20 at 10 48 39 AM

uwu

Screenshot 2024-06-20 at 10 49 03 AM
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:52pm
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:52pm
kassens commented 3 months ago

Do we have branding guidelines that should be linked near this place?

github-actions[bot] commented 3 months ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 ### ⚠️ Global Bundle Size Increased Page | Size (compressed) | |---|---| | `global` | `104.19 KB` _(🟡 +50 B)_ |
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

### Five Pages Changed Size The following pages changed size from the code in this PR compared to its base branch: Page | Size (compressed) | First Load | |---|---|---| | `/404` | `104.28 KB` _(🔴 +23.49 KB)_ | 208.47 KB | | `/500` | `104.27 KB` _(🔴 +23.49 KB)_ | 208.46 KB | | `/[[...markdownPath]]` | `106.12 KB` _(🔴 +23.49 KB)_ | 210.31 KB | | `/errors` | `104.48 KB` _(🔴 +23.49 KB)_ | 208.68 KB | | `/errors/[errorCode]` | `104.46 KB` _(🔴 +23.49 KB)_ | 208.66 KB |
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

rickhanlonii commented 3 months ago

@kassens let's follow up with that, I'm not sure exactly what we need for the guidelines