Open EastSun5566 opened 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
19-react-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 10:23am |
react-dev | ✅ Ready (Inspect) | Visit Preview | Jul 13, 2024 10:23am |
Hi @EastSun5566!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hi React team,
Thanks for the great doc!
I noticed in the following file that the initial state of the
age
is set as a string:https://github.com/reactjs/react.dev/blob/4c91abc78b20be10e7d40cf57a80a6a6247e6e9a/src/content/reference/react-dom/components/input.md?plain=1#L351
https://github.com/reactjs/react.dev/blob/4c91abc78b20be10e7d40cf57a80a6a6247e6e9a/src/content/reference/react-dom/components/input.md?plain=1#L376
Given this, I believe converting the
age
back to a string would be more consistent before setting it withsetAge
. This would maintain type consistency throughout the component.Thank you!