Closed k35o closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
19-react-dev | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 22, 2024 7:22am |
react-dev | ✅ Ready (Inspect) | Visit Preview | Aug 22, 2024 7:22am |
Hi @k35o!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@harish-sethuraman
The latest version of Chrome fixes this issue. Should I revert?
Chrome Light
Dark
[Additional information] Dark mode in Safari remains difficult to view.
Its better that we keep the ✅. Not everyone are on latest always as well. white check mark has better visibility over all
Overview
✔ surrounded by syntax highlighting cannot be viewed in Chrome because they are buried in it (Safari and Firefox can view them). Therefore, I have replaced ✔ with ✅ so that it can be visualised in any browser.
Background
The italic form of ✔ is not supported by Source Code Pro. If not supported, Chrome display empty character, but other browsers display normal style ✔ instead.
Relevant section.
https://react.dev/learn/conditional-rendering#conditional-ternary-operator--