search

reactjs / react.dev

The React documentation website
https://react.dev/
Creative Commons Attribution 4.0 International
11.07k stars 7.55k forks source link

Explicitly redirect from legacy 'thinking-in-react' page #7143

Closed BartoszKlonowski closed 1 month ago

BartoszKlonowski commented 2 months ago

This pull request fixes #7142

Although the thinking-in-react page redirect already works for https://reactjs.org/docs/thinking-in-react.html, making it explicit redirect also fixes the scenario where the link has the legacy path /docs/ but the current website react.dev.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 7:21am
react-dev ✅ Ready (Inspect) Visit Preview Sep 3, 2024 7:21am
github-actions[bot] commented 2 months ago

Size changes

## 📦 Next.js Bundle Analysis for react-dev This analysis was generated by the [Next.js Bundle Analysis action](https://github.com/hashicorp/nextjs-bundle-analysis). 🤖 This PR introduced no changes to the JavaScript bundle! 🙌
sophiebits commented 2 months ago

Hmm, are we linking to this path somewhere? I would have thought that this path has never been valid on this domain so we shouldn't need a redirect.

rickhanlonii commented 1 month ago

Similar to the comment here, we don't do redirects like this: https://github.com/reactjs/react.dev/pull/7162#issuecomment-2383673202