Incomplete documentation on creating web components

reactjs / react.dev

The React documentation website

https://react.dev/

Creative Commons Attribution 4.0 International

11.06k stars 7.56k forks source link

Incomplete documentation on creating web components #72

Open bvaughn opened 7 years ago

bvaughn commented 7 years ago

This issue was originally reported by @LukasBombach via facebook/react/issues/10155

Text of original issue:

your documentation on creating web components with react is quite cool and works really nice for the html. However, any component created this way will be unstyled as the documentation does not cover how to add CSS to the web component. Using create-react-app all your CSS will end up in a main.hash.css file and have selectors for your components, but when you create a web component, you css must be encapsulated in the component as the the components DOM lives in the shadow root and is not stylable from outside.

It would be cool if you could show a way to account for this.

raunofreiberg commented 6 years ago

Is this still relevant? I would be happy to start this off @bvaughn

bvaughn commented 6 years ago

This issue is all yours! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

LukasBombach commented 6 years ago

Hey there, original reporter here. The problem with react and web components is

Events will not work (because they are listened to at the root of the website where they don't end up from a web component). I have written a workaround / hack for this: https://github.com/WeltN24/react-shadow-dom-retarget-events
It's hard to get CSS in the shadow dom as it won't be applied from the website. I have written a webpack-loader for this which adds style tags to the shadow dom: https://github.com/WeltN24/react-web-component-style-loader . But that is not a real solution. The point is to discuss a proper solution for this problem.