search

reactome / container

:construction: Repository for files for running a Reactome production-like environment inside a docker container. Currently, this project's status is "Work-In-Progress". :construction:
9 stars 4 forks source link

build CuratorTool from maven_buils.sh #7

Closed SolomonShorser-OICR closed 7 years ago

SolomonShorser-OICR commented 7 years ago

maven_builds.sh will need to be updated to call the new ant build task to compile the Java source of CuratorTool. This needs to be done as a precursor to building "reactome.jar".

SolomonShorser-OICR commented 7 years ago

This issue: https://github.com/reactome/container/issues/8 needs to be completed before this issue can be completed.

AyushyaChitransh commented 7 years ago

In building CreatorTool, do we want to build jar files from all .xml files present in ANT folder of curator tool? Or are we talking about the CuratorTool/ant/CuratorToolBuild.xml. For now, I am working on CuratorToolBuild.xml, because in both cases, it will be needed.

AyushyaChitransh commented 7 years ago

Target named bundleapp has not been included as it was a MacOS X application, and I needed to confirm if it is to be included or not. If it is not required then commit 30301fb5f655de2f8a9d3cd125f439b93b9b12f8 closes this issue.

SolomonShorser-OICR commented 7 years ago

I don't think that bundleapp is necessary right now. We don't need to run CuratorTool on OS X, we need to compile enough of CuratorTool so that we can build reactome.jar and since it looks like reactome.jar now builds OK, I'm going to close this issue.