Fix for platform-dependent line separator in part 06 assertions

reactor / lite-rx-api-hands-on

Lite Rx API Hands-On with Reactor Core 3

1.05k stars 959 forks source link

Fix for platform-dependent line separator in part 06 assertions #83

Closed rohanmukesh closed 3 years ago

rohanmukesh commented 3 years ago

As suggested by @simonbasle in "https://github.com/reactor/lite-rx-api-hands-on/issues/82" I have modified the source code to avoid platform-dependent line separator. This is merge request for solution branch. I will soon create PR for master once this PR is approved

simonbasle commented 3 years ago

There shouldn't be a need to target the solution branch as this only touches tests, which are defined in the master branch. I've re-targeted this PR after having validated that the tests pass, and the code looks good.

Can you just rebase the branch so that compared to master it only contains your one commit, @rohanmukesh ?

rohanmukesh commented 3 years ago

@simonbasle I just did rebase compared to master. It now has only 1 commit. Please take a look. Thanks.