search

reactor / lite-rx-api-hands-on

Lite Rx API Hands-On with Reactor Core 3
1.05k stars 959 forks source link

Fixed AssertException in Windows Environment and add reactor-adapter … #84

Closed fugui closed 3 years ago

fugui commented 3 years ago

…dependence.

I completed those hands-on, but I found two problems : a. there need a dependence of reactor-adapter for test Part09Adapt. b. those log should be \r\n in windows environment, not \n.

simonbasle commented 3 years ago

Thanks for the PR @fugui. The windows issue has been fixed in parallel, see #83.

As to the reactor-addons dependency, it is not needed. The head comment in Part09Adapt actually explicitly points to it: https://github.com/reactor/lite-rx-api-hands-on/blob/master/src/main/java/io/pivotal/literx/Part09Adapt.java#L36