search

reactor / reactor-core

Non-Blocking Reactive Foundation for the JVM
http://projectreactor.io
Apache License 2.0
4.99k stars 1.21k forks source link

[doc] Document when groupBy can deadlock because of backpressure #3872

Closed NamrataGuptaRoy closed 3 months ago

NamrataGuptaRoy commented 3 months ago

Adds documentation for the 4 groupBy overloads about the scenario where backpressure can cause a deadlock with groupBy and suggesting how it could be avoided. Adds example of deadlock with groupBy and concatMap in the reference documentation.

See #3443

pivotal-cla commented 3 months ago

@NamrataGuptaRoy Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 months ago

@NamrataGuptaRoy Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 3 months ago

@NamrataGuptaRoy Thank you for signing the Contributor License Agreement!

chemicL commented 3 months ago

@NamrataGuptaRoy ef152df80d57713f9d33cb6080d8f2ee2b90d093 contains my alterations - mostly formatting and styling. One thing I wanted to clarify was the notion of consumption rate. I believe that term would have been misleading, as the rate didn't have any significance in the scenarios provided - it was the consumption pattern (concurrency too low) that prevented progress. The rate could have been enormous and nothing would have changed :)