reactor / reactor-kafka

Reactive Kafka Driver with Reactor
http://projectreactor.io
613 stars 227 forks source link

Metrics reactor_{receiver|sender}_active{sum|count|bucket} always shows 0 #377

Open patpatpat123 opened 8 months ago

patpatpat123 commented 8 months ago

Hello team,

I would like to report an issue regarding some metrics of reactor kafka.

Once adding this to the code:

return KafkaReceiver.create(receiverOptions
                .consumerListener(new MicrometerConsumerListener(registry))

  return KafkaSender.create(senderOptions
                .producerListener(new MicrometerProducerListener(registry)));

We get many useful metrics. If nothing else, I would like to thank reactor team again for enabling metrics for this project.

However, it seems there is an issue with three metrics in particular.

The metrics are:

reactor_kafka_receiver_active_sum
reactor_kafka_receiver_active_count
reactor_kafka_receiver_active_bucket
reactor_kafka_sender_active_sum
reactor_kafka_sender_active_count
reactor_kafka_sender_active_bucket

They always show 0, no matter how much traffic, or how long the app is active.

This is also quite strange, as the counterparts do have values.

reactor_kafka_receiver_sum
reactor_kafka_receiver_count
reactor_kafka_receiver_bucket
reactor_kafka_sender_sum
reactor_kafka_sender_count
reactor_kafka_sender_bucket

Therefore, it seems:

Issue 1: maybe reactor_{receiver|sender}active{sum|count|bucket} metrics are just duplicates of metrics reactor{receiver|sender}{sum|count|bucket}, without value, hence, we should remove those reactor{receiver|sender}_active{sum|count|bucket} metrics .

Issue 2: the two are not duplicates, but the value is populated for reactor{receiver|sender}{sum|count|bucket}, but not for reactor_{receiver|sender}_active{sum|count|bucket}.

Thank you for your time reading this.

KafkaProServerless commented 7 months ago

same issue here. Reactor kafka team, could you please help?