TODO: Timeout - Githubissues

reactphp-legacy / whois

Whois client based on ReactPHP.

MIT License

71 stars 15 forks source link

TODO: Timeout #3

Open umpirsky opened 12 years ago

umpirsky commented 12 years ago

I'm interested to contribute fix for timeout handling. I just need some help.

@igorw What is the right place to implement this? I looked into React\Socket\Connection hoping it supports timout, but looks like it doesn't.

igorw commented 12 years ago

By timeout, do you mean an unresponsive server that never closes the connection?

umpirsky commented 12 years ago

Yes, did you have same timeout in mind?

igorw commented 12 years ago

Well, I think it's a more general issue that we should try to solve on a higher level. See also: promises

umpirsky commented 12 years ago

Looks great, but will add complexity to current implementation. I was looking for simple timeout feature. I'm not really into this React thing yet, but I expected that there is a HTTP client, and they usually support timeout.