Drop child process adapter

reactphp / filesystem

Evented filesystem access.

MIT License

135 stars 40 forks source link

Drop child process adapter #109

Closed WyriHaximus closed 2 years ago

WyriHaximus commented 2 years ago

While fully non-blocking the child process adapter is a factor 100 slower than all the other adapters combined, including the blocking fallback adapter. As such removing it wil increase performance for everyone not having ext-uv or ext-eio (coming in a follow-up PR) installed. Even at the cost of blocking for a short period of time.

clue commented 2 years ago

Closed as duplicate of #108

WyriHaximus commented 2 years ago

Thanks, seems my commute connection was flaky at that moment.