search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Support both evenement 3.0 and 2.0 (and react/stream) #22

Closed WyriHaximus closed 6 years ago

WyriHaximus commented 6 years ago

Événement 3.0 is nearly fully backwards compatible with 2.0 and react/filesystem is fully compatible with all three so why not support it. It packs some neat performance upgrades without any code changes on react/filesystem's side :shipit: .

WyriHaximus commented 6 years ago

@clue good point, I'll look into that after I fixed the current reason builds fail

ghost commented 6 years ago

I have seen that wyrihaximus/react-child-process-messenger locks reactphp/stream down to max. v0.5 by requiring reactphp/child-process v0.4. There seems to be a PR for this, but there hasn't been any recent activity.

WyriHaximus commented 6 years ago

@CharlotteDunois you mean this PR https://github.com/WyriHaximus/reactphp-child-process-messenger/pull/13 ? There are some things locally I want to push and finish before merging it, once tagged the only thing in the chain requiring stream 0.4 is this package it self.

WyriHaximus commented 6 years ago

@clue done :+1:

WyriHaximus commented 6 years ago

Follow up with fixes for failing tests are coming soon as well 👍