search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Create random directories within our own temporary test directory #27

Closed WyriHaximus closed 6 years ago

clue commented 6 years ago

Just curious, what is the motivation for this change?

WyriHaximus commented 6 years ago

The motivation behind the change back then was to ensure we're in our own little walled directory where we decide the rules to mitigate the permission issues some tests have. But #30 might make this PR obsolete.

WyriHaximus commented 6 years ago

Ping @jsor @clue

clue commented 6 years ago

The motivation behind the change back then was to ensure we're in our own little walled directory where we decide the rules to mitigate the permission issues some tests have

Not a big fan of this, but it it helps getting the tests green… ¯(ツ)/¯ IMO we should clean up this up once the outstanding issues have been fixed.