search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Test reading and writing from and to binary files #39

Closed WyriHaximus closed 6 years ago

WyriHaximus commented 6 years ago

Fixes / Closes #38

WyriHaximus commented 6 years ago

Ping @jsor @clue, rebased it on master and tests are passing

clue commented 6 years ago

Not a big fan of the overhead that base64 encoding incurs, but seeing it fixes a relevant bug, I'm okay with this for now :+1:

WyriHaximus commented 6 years ago

@clue neither am I, but I'm up for suggestions in 0.2.0. One could be two methods, one for text files and one for binary files.