Closed ghost closed 5 years ago
Right so there is a lot of good stuff in this PR and I'm really happy with that but it is basically to big to review in its current state. So I would prefer we break this up in separate PR's. Preferable starting with Remove opinionated usage of a specific adapter in stream
so we can release that as part of v0.1.3
, before moving on to all the breaking changes for v0.2
.
Now I appreciate the huge effort you put into all the fixes and the new pthreads
adapter and I know that asking to split this up isn't going to speed this up initially but it will allows us to iterate over smaller PR's faster then a single huge one.
This PR refactors the unit tests to be functional for the adapters, instead of mocking them, to test their implementation - not the expected stacktrace. This PR also changes some other things, such as:
new FulfilledPromise
->React\Promise\resolve
new RejectedPromise
->React\Promise\reject
count
anymore for the file descriptor - instead one will be generated using PHP7's random bytes APIls
has been made to use a promise, instead of a stream (made compatible to the interface)symlink
have been renamed to be not ambiguous anymoreCharlotteDunois/Phoebe
for pthreads pool with messaging and event looped workerThe PR commits will be squashed once review is positive. This PR includes and closes #46.